Matthias Clasen [Mon, 4 May 2020 14:51:11 +0000 (10:51 -0400)]
Adwaita: Style .toolbar
We don't have GtkToolbar anymore, so we are more likely
to meet a .toolbar style class, than a toolbar element.
Matthias Clasen [Mon, 4 May 2020 14:50:34 +0000 (10:50 -0400)]
widget-factory: Add .toolbar
We dropped GtkToobar, but we still want to present
something that looks the part here, so add a style
class.
Matthias Clasen [Mon, 4 May 2020 12:31:25 +0000 (12:31 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!1823
Matthias Clasen [Sun, 3 May 2020 15:44:00 +0000 (11:44 -0400)]
testframe: Drop padding
No need to emulate features that GtkFrame no longer has.
Matthias Clasen [Sun, 3 May 2020 15:41:57 +0000 (11:41 -0400)]
frame: Fix xalign handling
SEtting a nonzero xalign on frames had no
effect, since we were always using the full
allocation with here, instead of what the label
needs. Found by using testframe for a second.
Matthias Clasen [Sun, 3 May 2020 15:39:58 +0000 (11:39 -0400)]
frame: Don't queue a resize if xalign changes
We only need to allocate children in this case.
While we touch it, rewrite the setter to modern
style.
Jakub Steiner [Mon, 4 May 2020 10:24:32 +0000 (10:24 +0000)]
Merge branch 'wip/jimmac/avoid-wobbly-windows' into 'master'
Adwaita: make transition offset more subtle
See merge request GNOME/gtk!1822
Jakub Steiner [Mon, 4 May 2020 09:29:19 +0000 (11:29 +0200)]
Adwaita: make transition offset more subtle
- be less like wobbly windows
Jakub Steiner [Mon, 4 May 2020 08:49:40 +0000 (08:49 +0000)]
Merge branch 'wip/jimmac/emphasize-focus-change' into 'master'
Adwaita: bring more attention to focus change
See merge request GNOME/gtk!1803
Cheng-Chia Tseng [Sun, 3 May 2020 13:29:03 +0000 (13:29 +0000)]
Update Chinese (Taiwan) translation
Matthias Clasen [Sun, 3 May 2020 01:10:24 +0000 (01:10 +0000)]
Merge branch 'filechooser-translation' into 'master'
filechooser: Translate type column
Closes #2690
See merge request GNOME/gtk!1816
Matthias Clasen [Sat, 2 May 2020 23:57:38 +0000 (19:57 -0400)]
filechooser: Translate type column
When the code for this was copied from nautilus,
we forgot to adapt it for running in a library
instead of an application - gettext() doesn't work
in a library.
Fixes: #2690
Matthias Clasen [Sat, 2 May 2020 20:06:08 +0000 (20:06 +0000)]
Merge branch 'wip/exalm/subtitle' into 'master'
appchooserdialog: Don't show subtitle label when subtitle is null
See merge request GNOME/gtk!1815
Alexander Mikhaylenko [Sat, 2 May 2020 18:34:58 +0000 (23:34 +0500)]
appchooserdialog: Don't show subtitle label when subtitle is null
Looks like
67822d0c9a23f6db7e816fd6466720c167dcbe7f and
3f1bd3722dd3374bef07346138a0ed9e95d3b9fe collided, and subtitle can be null
now. Add a check so that we don't end up with empty label in that case.
Yuri Chornoivan [Sat, 2 May 2020 06:27:02 +0000 (06:27 +0000)]
Update Ukrainian translation
Matthias Clasen [Fri, 1 May 2020 21:09:38 +0000 (21:09 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
docs: Add more detail to the drawing overview
See merge request GNOME/gtk!1811
Benjamin Otte [Fri, 1 May 2020 19:39:27 +0000 (19:39 +0000)]
Merge branch 'wip/exalm/headerbar-title' into 'master'
Headerbar title/subtitle cleanups
See merge request GNOME/gtk!1807
Asier Sarasua Garmendia [Fri, 1 May 2020 19:25:55 +0000 (19:25 +0000)]
Update Basque translation
Matthias Clasen [Fri, 1 May 2020 18:17:26 +0000 (14:17 -0400)]
widget-factory: Fix a typo
We wanted to move the conflicting global shortcuts
to the bubble phase, so they don't override the
entry bindings.
Matthias Clasen [Fri, 1 May 2020 16:21:42 +0000 (12:21 -0400)]
dragicon: Derive from GtkWidget
This wasn't meant to derive from GtkContainer.
Matthias Clasen [Fri, 1 May 2020 16:12:18 +0000 (12:12 -0400)]
docs: Add more detail to the drawing overview
Matthias Clasen [Fri, 1 May 2020 18:13:12 +0000 (18:13 +0000)]
Merge branch 'for-master' into 'master'
appchooserdialog: Don't show broken subtitles
See merge request GNOME/gtk!1809
Alexander Mikhaylenko [Fri, 1 May 2020 15:10:52 +0000 (20:10 +0500)]
headerbar: Document GtkBuilder child types, add a title example
Florian Müllner [Fri, 1 May 2020 15:01:34 +0000 (17:01 +0200)]
appchooserdialog: Don't show broken subtitles
Commit
07beb6dba29 made GtkAppChooserWidget useful with no content-type,
however when used in a GtkAppChooserDialog, this will lead to a confusing
"Opening (null) files" subtitle.
Fix this by omitting the subtitle altogether in that case.
Matthias Clasen [Fri, 1 May 2020 16:02:43 +0000 (16:02 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
docs: Some revisions of the input overview
See merge request GNOME/gtk!1808
Yuri Chornoivan [Fri, 1 May 2020 15:56:57 +0000 (15:56 +0000)]
Update Ukrainian translation
Alexander Mikhaylenko [Fri, 1 May 2020 13:48:03 +0000 (18:48 +0500)]
builder-tool: Rename GtkHeaderBar:custom-title to title-widget
Add a test.
Alexander Mikhaylenko [Thu, 30 Apr 2020 23:17:27 +0000 (04:17 +0500)]
headerbar: Rename custom-title to title-widget
Now that all the other title-related properties are gone, custom title can
have a more mundane name.
Alexander Mikhaylenko [Thu, 30 Apr 2020 23:04:08 +0000 (04:04 +0500)]
headerbar: Remove user-settable title
Use window title, or custom title widget if it's set. Remove 'title'
property.
Update demos and tests to set the title on the window instead of
headerbar.
Alexander Mikhaylenko [Thu, 30 Apr 2020 20:27:05 +0000 (01:27 +0500)]
headerbar: Remove subtitle
Also remove the box containing title and subtitle, as there's only one
label now.
Alexander Mikhaylenko [Thu, 30 Apr 2020 20:08:57 +0000 (01:08 +0500)]
filechooserdialog: Create title and subtitle manually
title and subtitle properties will go away in the following commits, stop
using them.
Alexander Mikhaylenko [Thu, 30 Apr 2020 19:42:37 +0000 (00:42 +0500)]
appchooserdialog: Create title and subtitle manually
title and subtitle properties will go away in the following commits, stop
using them.
Alexander Mikhaylenko [Thu, 30 Apr 2020 18:47:53 +0000 (23:47 +0500)]
headerbar: Remove has-subtitle property
Subtitle will go too in the next commit, but has-subtitle goes first as
it's broken right now anyway.
Matthias Clasen [Fri, 1 May 2020 13:26:06 +0000 (09:26 -0400)]
docs: Some revisions of the input overview
Remove some less than accurate details, and add
an illustration.
Matthias Clasen [Fri, 1 May 2020 12:02:13 +0000 (12:02 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Keynav improvements for widget-factory
See merge request GNOME/gtk!1804
Piotr Drąg [Fri, 1 May 2020 09:56:37 +0000 (11:56 +0200)]
Update POTFILES.in and POTFILES.skip
Matthias Clasen [Fri, 1 May 2020 00:08:15 +0000 (20:08 -0400)]
widget-factory: Improve demo keynav
We have example cut/copy/paste actions for which we want
the usual shortcuts to show up in the menus, but they should
not break the expected shortcuts in entries. So, move them
to a capture phase shortcut controller.
Matthias Clasen [Thu, 30 Apr 2020 23:18:09 +0000 (19:18 -0400)]
widget-factory: Add mnemonics to the stack pages
Matthias Clasen [Thu, 30 Apr 2020 23:17:34 +0000 (19:17 -0400)]
stack: Add a :use-underline property
Add GtkStackPage:use-underline, and use it when
constructing labels in the stack switcher.
Matthias Clasen [Thu, 30 Apr 2020 22:57:33 +0000 (22:57 +0000)]
Merge branch 'speed-up-event-matching' into 'master'
keymap: Cache key info
See merge request GNOME/gtk!1800
Jakub Steiner [Thu, 30 Apr 2020 20:40:21 +0000 (22:40 +0200)]
Adwaita: bring more attention to focus change
- as discussed in https://gitlab.gnome.org/GNOME/gtk/-/issues/2644 it's desirable to bring attention to what's focused. Instead of pressing `alt` just simply changing focus with `tab` can have a similar effect
Extends https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1802
Jakub Steiner [Thu, 30 Apr 2020 18:35:57 +0000 (18:35 +0000)]
Merge branch 'theme-focus-ring-mixin' into 'master'
Adwaita: Use a mixin for visible focus rings
Closes #2653
See merge request GNOME/gtk!1802
Matthias Clasen [Thu, 30 Apr 2020 04:33:06 +0000 (00:33 -0400)]
keymap: Cache key info
We currently calling gdk_display_map_keyval up to
once per key event per shortcut trigger, and that function
does an expensive loop over the entire keymap and
allocates an array. Avoid this by caching the entries
in a single array, and have a lookup table for finding
the entries for a keyval.
To do this, change the GdkKeymap.get_entries_for_keyval
signature, and change the ::keys-changed signal to be
RUN_FIRST, since we want to clear the cache in the class
handler before running signal handlers. These changes are
possible now, since keymaps are no longer public API.
nana-4 [Thu, 30 Apr 2020 14:15:04 +0000 (23:15 +0900)]
Adwaita: Use a mixin for visible focus rings
The focus-ring() mixin allows we to flexibly style the focus ring for
each widget. By using this, we can get rid of the "Outlines" section,
which is out of place in the _common.scss file.
This commit also has the following changes:
- Transition the focus rings on most widgets.
- Add a missing focus ring to iconview.
- Move the expander-widget focus ring to its title.
- Move the notebook focus ring to its checked tab.
Closes https://gitlab.gnome.org/GNOME/gtk/-/issues/2653
Daniel Mustieles [Thu, 30 Apr 2020 10:53:45 +0000 (12:53 +0200)]
Updated Spanish translation
Daniel Mustieles [Thu, 30 Apr 2020 10:53:01 +0000 (12:53 +0200)]
Updated Spanish translation
Matthias Clasen [Thu, 30 Apr 2020 01:31:36 +0000 (01:31 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
docs: Move menu model docs
See merge request GNOME/gtk!1799
Matthias Clasen [Thu, 30 Apr 2020 00:27:32 +0000 (20:27 -0400)]
docs: Move menu model docs
It makes more sense to document the menu model XML
format in the GtkPopoverMenu docs than in
GtkApplicationWindow.
Matthias Clasen [Wed, 29 Apr 2020 22:14:09 +0000 (22:14 +0000)]
Merge branch 'win32-new-runner' into 'master'
CI: Switch to new Windows runners
See merge request GNOME/gtk!1797
Yuri Chornoivan [Wed, 29 Apr 2020 20:16:31 +0000 (20:16 +0000)]
Update Ukrainian translation
Yuri Chornoivan [Wed, 29 Apr 2020 20:15:38 +0000 (20:15 +0000)]
Update Ukrainian translation
Christoph Reiter [Wed, 29 Apr 2020 17:36:40 +0000 (19:36 +0200)]
CI: Switch to new Windows runners
They use powershell instead of cmd.exe, use the tag win32-ps instead of win32,
and run Windows 2016 instead of 2012r2.
The old runners will be switched off in the comming weeks.
Matthias Clasen [Wed, 29 Apr 2020 15:29:02 +0000 (15:29 +0000)]
Merge branch 'soundcheck' into 'master'
Add a quick sound test
See merge request GNOME/gtk!1796
Matthias Clasen [Wed, 29 Apr 2020 14:54:40 +0000 (10:54 -0400)]
Add a quick sound test
Just to show that our media infrastructure is up
to playing little beeps and bings.
Emmanuele Bassi [Wed, 29 Apr 2020 13:39:44 +0000 (13:39 +0000)]
Merge branch 'ebassi/for-master' into 'master'
Ebassi/for master
See merge request GNOME/gtk!1795
Emmanuele Bassi [Wed, 29 Apr 2020 11:49:35 +0000 (12:49 +0100)]
docs: Link the license file from the README
Emmanuele Bassi [Wed, 29 Apr 2020 11:49:05 +0000 (12:49 +0100)]
docs: Link the contribution guide from the README
Hopefully people will read it.
Emmanuele Bassi [Wed, 29 Apr 2020 11:47:57 +0000 (12:47 +0100)]
docs: Update link to the discussion forum
The README file still links to the old web page about mailing lists; the
link is now a 404 after the website redesign, and we don't use mailing
lists any more, in favour of Discourse.
Matthias Clasen [Wed, 29 Apr 2020 11:34:07 +0000 (11:34 +0000)]
Merge branch 'wip/jtojnar/join-paths' into 'master'
build: clean up .pc generation
See merge request GNOME/gtk!1793
Jan Tojnar [Wed, 29 Apr 2020 05:42:38 +0000 (07:42 +0200)]
build: clean up .pc generation
Path concatenation is much nicer than the unwieldy format method.
Since paths returned by get_option are relative to prefix, they will be joined as before.
As a bonus, this fixes weird platforms like NixOS that actually pass absolute includedir under a different prefix.
Matthias Clasen [Wed, 29 Apr 2020 04:47:39 +0000 (04:47 +0000)]
Merge branch 'popup-positioning-fix' into 'master'
popover: Fix repositioning logic
See merge request GNOME/gtk!1792
Matthias Clasen [Wed, 29 Apr 2020 03:26:19 +0000 (23:26 -0400)]
popover: Fix repositioning logic
When the arrow changes position, we need to queue
an allocation to ensure that gtk_widget_allocate
actually calls our ->size_allocate vfunc.
Matthias Clasen [Wed, 29 Apr 2020 02:04:37 +0000 (02:04 +0000)]
Merge branch 'class-action-init' into 'master'
Reshuffle action muxer initialization
See merge request GNOME/gtk!1789
Matthias Clasen [Wed, 29 Apr 2020 00:55:01 +0000 (00:55 +0000)]
Merge branch 'drop-stack-homogeneous' into 'master'
Drop stack homogeneous
Closes #2673
See merge request GNOME/gtk!1791
Matthias Clasen [Wed, 29 Apr 2020 00:22:26 +0000 (20:22 -0400)]
Speed up class action hookup
No need to construct a detailed signal name for
every action when we can just look up the signal ID
once and use the quark that the GParamSpec already
has. Also, we don't need to loop over the actions
every time we get a notification.
Matthias Clasen [Tue, 28 Apr 2020 23:59:13 +0000 (19:59 -0400)]
builder-tool: Replace GtkStack:homogeneous
Replace this property by h/vhomogeneous.
Add a test.
Matthias Clasen [Tue, 28 Apr 2020 23:53:33 +0000 (19:53 -0400)]
Drop GtkStack:homogeneous
We have hhomogeneous and vhomogeneous properties
that can be set individually.
Fixes: #2673
Matthias Clasen [Tue, 28 Apr 2020 22:41:16 +0000 (22:41 +0000)]
Merge branch 'popup-controls-hiding' into 'master'
video: Don't hide the controls while the popup is shown
See merge request GNOME/gtk!1787
Matthias Clasen [Tue, 28 Apr 2020 22:34:23 +0000 (18:34 -0400)]
Reshuffle action muxer initialization
We were having a problem where property actions were
not getting state updates because prop_actions_connect
was triggered from some instance_init function while
the widget class is not in place yet.
Delay that call until the widget is fully constructed,
so we can guarantee that we are dealing with the
correct class private struct, and see all class actions.
Matthias Clasen [Tue, 28 Apr 2020 20:29:36 +0000 (20:29 +0000)]
Merge branch 'widget-factory-larger-logo' into 'master'
Widget factory larger logo
See merge request GNOME/gtk!1786
Matthias Clasen [Tue, 28 Apr 2020 19:11:26 +0000 (15:11 -0400)]
video: Don't hide the controls while the popup is shown
We don't get motion events from the popup (due to grabs),
so just don't hide as long as we're grab shadowed. This
makes the controls stay up until the volume popup is
dismissed.
Matthias Clasen [Tue, 28 Apr 2020 17:04:10 +0000 (13:04 -0400)]
Use a slightly larger version of the logo animation
This is large enough to not make the media controls
slider shrink to nothing.
Daniel Mustieles [Tue, 28 Apr 2020 15:49:39 +0000 (17:49 +0200)]
Updated Spanish translation
Emmanuele Bassi [Tue, 28 Apr 2020 14:11:55 +0000 (14:11 +0000)]
Merge branch 'drop-realize-invariant' into 'master'
Drop parent->realized => child->realized invariant
See merge request GNOME/gtk!1783
Emmanuele Bassi [Tue, 28 Apr 2020 13:06:26 +0000 (13:06 +0000)]
Merge branch 'ebassi/for-master' into 'master'
Ebassi/for master
See merge request GNOME/gtk!1782
Alexander Larsson [Tue, 28 Apr 2020 12:32:57 +0000 (14:32 +0200)]
Drop parent->realized => child->realized invariant
We already dropped this invariant in gtk_widget_verify_invariants()
because it was not true in all cases. Also, it is not really useful
these days as we extended what it means to be a "child" to also
include widgets in different toplevels.
For example, a popup in a popup button need not be realized just
because the button is in a realized window. The main invariants
we want are:
* Parent is realized before child
* Widget is realized before it is mapped
This sounds like its not a huge deal, but in fact it is a massive win
for things like menus, because when we go between menus in a menubar
each switch between two open menus involves a lot of intermingled
crossing events to different surfaces and for each of these the
tooltip window of the toplevel gets assigned to the new surface. This
shouldn't be a huge deal, as the tooltip window is not even visible,
but due to the realized invariant it get re-realized each time it gets
re-assigned.
Emmanuele Bassi [Mon, 27 Apr 2020 13:46:23 +0000 (14:46 +0100)]
Annotate more functions returning GListModel
Now that we can have an element-type annotation, we should use it where
needed.
Emmanuele Bassi [Tue, 28 Apr 2020 12:24:06 +0000 (13:24 +0100)]
Use attributes instead of element-type annotation
The `element-type` annotation is for GList and GSList only, and turns
out adding support for GListModel in gobject-introspection breaks Vala
and the GIR for GIO.
Instead of using `element-type`, we can use the `attributes` annotation,
which is ignored by code generators based on the GIR data.
Matthias Clasen [Tue, 28 Apr 2020 05:25:50 +0000 (05:25 +0000)]
Merge branch 'inspector-media' into 'master'
Inspector media
See merge request GNOME/gtk!1781
Matthias Clasen [Tue, 28 Apr 2020 04:37:00 +0000 (00:37 -0400)]
inspector: Show the media backend
Matthias Clasen [Tue, 28 Apr 2020 04:37:14 +0000 (00:37 -0400)]
mediafile: Privately export function to the extension
We want to show this information in the inspector.
Matthias Clasen [Tue, 28 Apr 2020 03:42:01 +0000 (03:42 +0000)]
Merge branch 'popover-flip-arrow-fix' into 'master'
popover: Allocate after setting final_position
Closes #2671
See merge request GNOME/gtk!1780
Matthias Clasen [Tue, 28 Apr 2020 01:55:24 +0000 (01:55 +0000)]
Merge branch 'menu-section-title-fixup' into 'master'
popovermenu: Don't put a separator before the first section
Closes #2672
See merge request GNOME/gtk!1779
Matthias Clasen [Tue, 28 Apr 2020 00:58:03 +0000 (20:58 -0400)]
popover: Allocate after setting final_position
When we find out that we've been flipped, set
final_position and final_rect before allocating
the popover. This prevents 'smashed-in beak' disease.
Fixes: #2671
Matthias Clasen [Tue, 28 Apr 2020 00:26:02 +0000 (20:26 -0400)]
popovermenu: Don't put a separator before the first section
When we have section titles, we were not hiding the
separator before the first section as we should;
fix this.
Fixes: #2672
Matthias Clasen [Mon, 27 Apr 2020 23:15:40 +0000 (23:15 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
widget-factory: Enable page transitions by default
See merge request GNOME/gtk!1777
Matthias Clasen [Mon, 27 Apr 2020 18:33:07 +0000 (14:33 -0400)]
widget-factory: Enable page transitions by default
No need to make this an easter egg.
Daniel Mustieles [Mon, 27 Apr 2020 16:14:43 +0000 (18:14 +0200)]
Updated Spanish translation
Matthias Clasen [Mon, 27 Apr 2020 13:22:47 +0000 (13:22 +0000)]
Merge branch 'BUG_filechooser_async_data_loss_GTK4' into 'master'
GtkFilechooserWidget: prevent oblivious selection of file
See merge request GNOME/gtk!1688
Matthias Clasen [Mon, 27 Apr 2020 12:59:35 +0000 (12:59 +0000)]
Merge branch 'wip/exalm/tnum' into 'master'
mediacontrols: Use tabular figures for time and duration
See merge request GNOME/gtk!1774
Alexander Mikhaylenko [Mon, 27 Apr 2020 12:28:20 +0000 (17:28 +0500)]
mediacontrols: Use tabular figures for time and duration
In particular, this prevents gtk4-widget-factory from jumping every
second.
Matthias Clasen [Mon, 27 Apr 2020 12:16:54 +0000 (12:16 +0000)]
Merge branch '2657-avoid-use-after-free-suggestion' into 'master'
Resolve "Use-after-free crash in `thaw_updates()`"
Closes #2657
See merge request GNOME/gtk!1771
Matthias Clasen [Mon, 27 Apr 2020 12:11:37 +0000 (12:11 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Miscellaneous bug fixes
Closes #2666 and #2016
See merge request GNOME/gtk!1773
Matthias Clasen [Mon, 27 Apr 2020 04:35:47 +0000 (00:35 -0400)]
filechooser: Correct an annotation
Clarify that gtk_file_chooser_add_filter is only taking
ownership of a floating reference, which translates to
"transfer none", not "transfer full".
Fixes: #2016
Matthias Clasen [Mon, 27 Apr 2020 04:23:49 +0000 (00:23 -0400)]
placesview: Fix translator comments
These comments were applied to the wrong strings
by xgettext.
Fixes: #2666
Matthias Clasen [Mon, 27 Apr 2020 04:13:46 +0000 (00:13 -0400)]
filechooser: Fix type-to-search
We need to capture the keys and forward them
to the search entry, for anything to happen.
Matthias Clasen [Mon, 27 Apr 2020 03:30:30 +0000 (03:30 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!1772
Matthias Clasen [Mon, 27 Apr 2020 02:30:34 +0000 (22:30 -0400)]
widget-factory: Revamp transition effects
Use a quick crossfade for the main pages, and use
the rotation for the small stack on page 2, where
it looks less out of place.
Matthias Clasen [Mon, 27 Apr 2020 02:14:10 +0000 (22:14 -0400)]
gtk-demo: Add a shortcuts window
Its not very impressive here, but still good to have.
Matthias Clasen [Mon, 27 Apr 2020 01:59:28 +0000 (21:59 -0400)]
icon-browser: Add a gear menu
Add an about dialog, and make the inspector available.